← Back to task

Commit a436ffe5

commit a436ffe53e2a043865727506716cc6b213fa2f91
Author: Ben Sima <ben@bensima.com>
Date:   Wed Dec 31 10:57:15 2025

    pi-review.sh: Strip trailing punctuation from commit title
    
    Prevents gitlint T3 violations by stripping trailing ., !, ?
    from the task title before building the commit subject line.
    
    Task-Id: t-299

diff --git a/Omni/Ide/pi-review.sh b/Omni/Ide/pi-review.sh
index b5b3cf62..78c784ef 100755
--- a/Omni/Ide/pi-review.sh
+++ b/Omni/Ide/pi-review.sh
@@ -295,7 +295,9 @@ if [ "$DRY_RUN" = true ]; then
   case "$VERDICT" in
     APPROVE)
       COMMIT_PREFIX="${NAMESPACE:-$TASK_ID}"
-      SUBJECT="$COMMIT_PREFIX: $TITLE"
+      # Strip trailing punctuation from title (gitlint T3)
+      CLEAN_TITLE="${TITLE%[.!?]}"
+      SUBJECT="$COMMIT_PREFIX: $CLEAN_TITLE"
       if [ ${#SUBJECT} -gt 72 ]; then
         SUBJECT="${SUBJECT:0:69}..."
       fi
@@ -329,7 +331,9 @@ case "$VERDICT" in
     echo "Approved! Committing changes..."
     git add -A
     COMMIT_PREFIX="${NAMESPACE:-$TASK_ID}"
-    SUBJECT="$COMMIT_PREFIX: $TITLE"
+    # Strip trailing punctuation from title (gitlint T3)
+    CLEAN_TITLE="${TITLE%[.!?]}"
+    SUBJECT="$COMMIT_PREFIX: $CLEAN_TITLE"
     if [ ${#SUBJECT} -gt 72 ]; then
       SUBJECT="${SUBJECT:0:69}..."
     fi