← Back to task

Commit 7194f3c1

commit 7194f3c10bcdc7b22ff74e998a5c8d56da27d63b
Author: Ben Sima <ben@bensima.com>
Date:   Tue Dec 30 18:07:33 2025

    Omni/Ide.hs: Fix pi-review.sh commit subject to respect 72 char limit
    
    Automated via pi-review.
    
    Task-Id: t-289

diff --git a/Omni/Ide/pi-review.sh b/Omni/Ide/pi-review.sh
index 36a0fedc..0d66a8a0 100755
--- a/Omni/Ide/pi-review.sh
+++ b/Omni/Ide/pi-review.sh
@@ -279,8 +279,12 @@ if [ "$DRY_RUN" = true ]; then
   case "$VERDICT" in
     APPROVE)
       COMMIT_PREFIX="${NAMESPACE:-$TASK_ID}"
+      SUBJECT="$COMMIT_PREFIX: $TITLE"
+      if [ ${#SUBJECT} -gt 72 ]; then
+        SUBJECT="${SUBJECT:0:69}..."
+      fi
       echo "Would: git add -A"
-      echo "Would: git commit -m \"$COMMIT_PREFIX: $TITLE\" -m \"Automated via pi-review.\" --trailer \"Task-Id: $TASK_ID\""
+      echo "Would: git commit -m \"$SUBJECT\" -m \"Automated via pi-review.\" --trailer \"Task-Id: $TASK_ID\""
       echo "Would: task update $TASK_ID done"
       ;;
     REJECT)
@@ -309,7 +313,11 @@ case "$VERDICT" in
     echo "Approved! Committing changes..."
     git add -A
     COMMIT_PREFIX="${NAMESPACE:-$TASK_ID}"
-    git commit -m "$COMMIT_PREFIX: $TITLE" -m "Automated via pi-review." --trailer "Task-Id: $TASK_ID"
+    SUBJECT="$COMMIT_PREFIX: $TITLE"
+    if [ ${#SUBJECT} -gt 72 ]; then
+      SUBJECT="${SUBJECT:0:69}..."
+    fi
+    git commit -m "$SUBJECT" -m "Automated via pi-review." --trailer "Task-Id: $TASK_ID"
     task update "$TASK_ID" "done" --json > /dev/null
     echo "Task $TASK_ID marked as done."
     ;;