Consolidate duplicate patchsetCount/patchset_count JSON field naming

t-587.6·WorkTask·
·
·
·Omni/Task.hs
Parent:t-587·Created1 week ago·Updated1 week ago

Description

Edit

Consolidate duplicate JSON field naming (patchsetCount vs patchset_count).

Problem: The patchset output and task JSON emit both patchsetCount (camelCase, Haskell convention) and patchset_count (snake_case) with identical values. The shell script tries both with jq fallback: .patchset_count // .taskPatchsetCount // 0. This is confusing and error-prone.

Fix: 1. Pick one canonical name. Since the Haskell ToJSON instance uses taskPatchsetCount, standardize on that. 2. Remove the redundant patchset_count key from taskJsonWithTrailer in Omni/Task.hs. 3. Remove the redundant patchset_count key from doPatchset output. 4. Update the shell script's jq expressions to use only taskPatchsetCount. 5. Keep backward-compat alias in FromJSON only if there are existing persisted JSON files that use the old name (check if any exist).

Files: Omni/Task.hs, Omni/Ide/dev-review-release.sh

Timeline (14)

🔄[human]Open → InProgress1 week ago
💬[human]1 week ago

Implemented patchset JSON key cleanup in commit 08b84a49: removed legacy patchset_count keys from task output + patchset command output, updated dev-review-release jq readers, and doc references switched to taskPatchsetCount.

🔄[human]InProgress → Review1 week ago
🔄[system]Review → ReviewInProgress1 week ago
💬[human]1 week ago

Automation (review) patchset 1 attempt 1/5 failed for run review-t-587.6-20260211-184837.

🔄[human]ReviewInProgress → Review1 week ago
💬[human]1 week ago

Manual review due repeated CostExhausted on review run review-t-587.6-20260211-184837. Verified locally: typecheck.sh Omni/Task.hs passes; bild Omni/Task.hs passes; lint passes for Omni/Task.hs and Omni/Ide/dev-review-release.sh; runtime check confirms both 'task patchset --json' and 'task show --json' emit only taskPatchsetCount key. Commit reviewed: 08b84a49.

🔄[human]Review → Approved1 week ago
💬[human]1 week ago

Integrated commit 08b84a49 onto live as c1db8223 (manual integration due integrator budget exhaustion in agentd).

🔄[human]Approved → Done1 week ago